-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a Ranked list input modal #26926
Open
Contrabang
wants to merge
9
commits into
ParadiseSS13:master
Choose a base branch
from
Contrabang:ranked-list-input
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+212
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
TGUI
This PR modifies TGUI, will conflict
labels
Sep 28, 2024
ParadiseSS13-Bot
added
-Status: Awaiting approval
This PR is waiting for approval internally
-Status: Awaiting review
This PR is awaiting review from the review team
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
-Status: Awaiting approval
This PR is waiting for approval internally
labels
Sep 30, 2024
lewcc
reviewed
Oct 1, 2024
lewcc
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, don't have an amazing grip on TGUI but things look fine
ParadiseSS13-Bot
added
-Status: Awaiting merge
This PR is ready for merge
and removed
-Status: Awaiting review
This PR is awaiting review from the review team
labels
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Adds a Ranked list input modal. It is similar to a tgui list select modal, but instead of selecting one element, the user orders them by preference. When they click submit the order they are in will be set as the result.
Why It's Good For The Game
Makes it a lot easier to take in ranked user inputs. For example, first past the post map voting, or choosing their ERT prefs. (Not implemented in this PR.)
Images of changes
Current version has a little drag handle near each option
dreamseeker_JU7u69mVb2.mp4
Testing
See Above
Declaration
Changelog
NPFC